Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

bitfield-signing: remove util::jobs usage #5523

Merged
merged 5 commits into from
May 19, 2022
Merged

bitfield-signing: remove util::jobs usage #5523

merged 5 commits into from
May 19, 2022

Conversation

slumber
Copy link
Contributor

@slumber slumber commented May 13, 2022

Part of #4259

@slumber slumber added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 13, 2022
@slumber slumber marked this pull request as draft May 13, 2022 23:31
@slumber
Copy link
Contributor Author

slumber commented May 14, 2022

@rphmeier do we want to preserve the behavior of aborting tasks for deactivated leaves?

@rphmeier
Copy link
Contributor

@slumber yes, we should maintain that behavior.

@slumber slumber marked this pull request as ready for review May 16, 2022 12:40
@slumber slumber requested review from drahnr and rphmeier May 16, 2022 12:40
drahnr
drahnr reviewed May 16, 2022
View reviewed changes
node/core/bitfield-signing/src/lib.rs Outdated
if let LeafStatus::Stale = leaf.status {
gum::debug!(
target: LOG_TARGET,
hash = ?leaf.hash,
Copy link
Contributor

@drahnr drahnr May 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hash = ?leaf.hash,
relay_parent = ?leaf.hash,

Please see the https://github.com/paritytech/polkadot/blob/master/node/gum/README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I copied this part of the code with no modifications

drahnr
drahnr suggested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good 👍 a few nits to be resolved / issues to be created before we merge

drahnr
drahnr approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's do a burnin

@slumber slumber changed the title bitfield-signing: remove util::jobs usage [BURN-IN] bitfield-signing: remove util::jobs usage May 18, 2022
@slumber slumber changed the title [BURN-IN] bitfield-signing: remove util::jobs usage bitfield-signing: remove util::jobs usage May 18, 2022
@slumber
Copy link
Contributor Author

slumber commented May 18, 2022

LGTM - let's do a burnin

Done on Versi, all good

@drahnr
Copy link
Contributor

drahnr commented May 18, 2022

bot merge

@paritytech-processbot
Copy link

Error: Checks failed for 1d5eac9

drahnr
drahnr reviewed May 19, 2022
View reviewed changes
node/core/bitfield-signing/src/lib.rs
use polkadot_primitives::v2::{AvailabilityBitfield, CoreState, Hash, ValidatorIndex};
use sp_keystore::{Error as KeystoreError, SyncCryptoStorePtr};
use std::{iter::FromIterator, pin::Pin, time::Duration};
use std::{collections::HashMap, iter::FromIterator, time::Duration};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FromIterator is part of the std prelude in rust 2021

@drahnr drahnr merged commit f76067d into master May 19, 2022
@drahnr drahnr deleted the slumber-bitfield-signing-refactor branch May 19, 2022 11:01
vstakhov pushed a commit that referenced this pull request May 19, 2022
@slumber @vstakhov
bitfield-signing: remove util::jobs usage (#5523)
380356e
vstakhov added a commit that referenced this pull request May 19, 2022
@drahnr @vstakhov
@dependabot @maltekliemann @slumber @koute
overseer becomes orchestra (#5542)
64f0948 
* rename overseer-gen to orchestra

Also drop `gum` and use `tracing`.

* make orchestra compile as standalone

* introduce Spawner trait to split from sp_core

Finalizes the independence of orchestra from polkadot-overseer

* slip of the pen

* other fixins

* remove unused import

* Update node/overseer/orchestra/proc-macro/src/impl_builder.rs

Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io>

* Update node/overseer/orchestra/proc-macro/src/impl_builder.rs

Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io>

* orchestra everywhere

* leaky data

* Bump scale-info from 2.1.1 to 2.1.2 (#5552)

Bumps [scale-info](https://github.com/paritytech/scale-info) from 2.1.1 to 2.1.2.
- [Release notes](https://github.com/paritytech/scale-info/releases)
- [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md)
- [Commits](paritytech/scale-info@v2.1.1...v2.1.2)

---
updated-dependencies:
- dependency-name: scale-info
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add missing markdown code block delimiter (#5555)

* bitfield-signing: remove util::jobs usage  (#5523)

* Switch to pooling copy-on-write instantiation strategy for WASM (companion for Substrate#11232) (#5337)

* Switch to pooling copy-on-write instantiation strategy for WASM

* Fix compilation of `polkadot-test-service`

* Update comments

* Move `max_memory_size` to `Semantics`

* Rename `WasmInstantiationStrategy` to `WasmtimeInstantiationStrategy`

* Update a safety comment

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>

* Fix build

Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Malte Kliemann <mail@maltekliemann.com>
Co-authored-by: Chris Sosnin <48099298+slumber@users.noreply.github.com>
Co-authored-by: Koute <koute@users.noreply.github.com>
@ghzlatarev ghzlatarev mentioned this pull request Jul 29, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drahnr drahnr drahnr approved these changes

@rphmeier rphmeier rphmeier approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slumber @rphmeier @drahnr